Remove UnsupportedOperation from the fatal errors #5038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Jan 14, 2025
Comment on lines
-1342
to
-1344
| isFatal UnsupportedOperation = True | ||
| -- EADDRNOTAVAIL -- connect | ||
| -- EAFNOSUPPRT -- connect |
There was a problem hiding this comment.
Could you add a haddock comment why EAFNOSUPPORT should not be included.
bolt12
force-pushed
the
bolt12/fix-connect-error
branch
from
596a3e7 to
edfeb17
Compare
coot
previously requested changes
Jan 15, 2025
Co-authored-by: coot <[email protected]>
bolt12
added a commit
that referenced
this pull request
Jan 16, 2025
Remove UnsupportedOperation from the fatal errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.