ChurnMode refactored #4962
Draft
ChurnMode refactored #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Sep 20, 2024
•
coot
commented
- churn: code refactoring
Use a newtype for `ChurnMode`. ChurnMode follows `FetchMode`, hence a newtype actually makes more sense than a separate data type.
|
Let's wait with this PR until we decide how Genesis will be integrated. |
coot
force-pushed
the
coot/churnmode
branch
from
fada7c9 to
aab8d3b
Compare
|
Hasn't Genesis been integrated yet? |
On the top level, no - 9.3 became 10.0-pre and there wasn't time to do this. On the other hand, the integration work left to do is quite small once @coot typed-protocols new-api is merged into consensus as the Genesis integration PR is on top of it, and a few other PR's in node/api/cli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.