Integrate #4795 #940
Closed
Integrate #4795 #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @bolt12 🙌 I'll merge these changes into the 8.10 branch, which will be eventually merged into |
|
Feel free to close this once everything is merged then :) Or sooner, if you prefer |
coot
changed the title
|
This was cherry-picked in #1032. (Note however that there will be changes in this area again soon, see IntersectMBO/ouroboros-network#4839.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates changes in ouroboros-network #4795. Which basically removes the
computePeerscallback from diffusion functions and provides a cleaner interface for consensus.Note: This PR probably depends on #808 to be merged since bootstrap peers work has already been merged in ouroboros-network.