Add a query for vote delegatees #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlhammann
force-pushed
the
ch/vote-delegatee-query
branch
2 times, most recently
from
e806eb2 to
4e289fa
Compare
carlhammann
force-pushed
the
ch/vote-delegatee-query
branch
from
4e289fa to
0a46de1
Compare
jasagredo
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Looks good from the Consensus side. I'm unsure of two things that I don't know the details right now:
- the experimental or not dilemma you mentioned
- whether this should be included in
ShelleyNodeToClientVersion8which is officially unreleased I think, or not
Perhaps @amesgen knows the answer to these two questions
amesgen
requested changes
Nov 10, 2023
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Show resolved
Hide resolved
|
Thanks! Can you also add a changelog fragment? |
amesgen
approved these changes
Nov 10, 2023
ouroboros-consensus-cardano/changelog.d/20231110_165234_carl.hammann_vote_delegatee_query.md
Outdated
Show resolved
Hide resolved
carlhammann
force-pushed
the
ch/vote-delegatee-query
branch
from
ceaadb4 to
ac8a4c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, see this issue on
cardano-cli: We want to have a query returns the vote delegatees, given staking credentials. This functionality is currently missing (here, and thus in thecardano-api, which I want to use in the CLI).