Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getCurrentChainIO, use it for BlockContext acquisition #462

Closed
wants to merge 1 commit into from
Closed

Add getCurrentChainIO, use it for BlockContext acquisition #462

wants to merge 1 commit into from

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Oct 25, 2023

Motivation: see if this has any impact on performance, cf #461

nfrisby
nfrisby reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this diff does what we had discussed on the phone call today re Issue 461.

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ChainDB/Impl/Query.hs Show resolved Hide resolved
@amesgen
Add getCurrentChainIO, use it for BlockContext acquisition
ea76c46 
Motivation: see if this has any impact on performance
@amesgen amesgen force-pushed the amesgen/getCurrentChainIO branch from 51da60e to ea76c46 Compare October 25, 2023 15:01
@amesgen
Copy link
Member Author

amesgen commented Nov 20, 2023 •
edited
Loading

FTR: Very surprisingly, this seemed to have actually resulted in non-trivial performance improvements; see #513 for much more details.

@amesgen
Copy link
Member Author

amesgen commented May 31, 2024

This is no longer relevant, see #513

@amesgen amesgen closed this May 31, 2024
@amesgen amesgen deleted the amesgen/getCurrentChainIO branch May 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrisby nfrisby nfrisby left review comments

@jasagredo jasagredo Awaiting requested review from jasagredo jasagredo will be requested when the pull request is marked ready for review jasagredo is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk will be requested when the pull request is marked ready for review fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales will be requested when the pull request is marked ready for review dnadales is a code owner

@geo2a geo2a Awaiting requested review from geo2a geo2a will be requested when the pull request is marked ready for review geo2a is a code owner

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amesgen @nfrisby