Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-changelogs.sh: bugfix #1348

Merged
merged 1 commit into from
Dec 18, 2024
Merged

check-changelogs.sh: bugfix #1348

merged 1 commit into from
Dec 18, 2024

Conversation

nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Dec 18, 2024

Fixes #1347

@nfrisby
Copy link
Contributor Author

nfrisby commented Dec 18, 2024

This fix is a bit hacky --- I'm happy to replace it with someone else's better fix. EG My bash skills would require some brushing off to use an associate array here instead of this simple invariant we currently happen to have, for example.

@nfrisby nfrisby added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 592e11c Dec 18, 2024
13 checks passed
@nfrisby nfrisby deleted the nfrisby/bugfix-check-changelogs branch December 18, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasagredo jasagredo jasagredo approved these changes

@amesgen amesgen Awaiting requested review from amesgen amesgen is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

@geo2a geo2a Awaiting requested review from geo2a geo2a is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check-changelogs.sh is looking for changelog.d in the wrong directory
2 participants
@nfrisby @jasagredo