Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent README.md and CODE-OF-CONDUCT.md to trigger CI #236

Closed
wants to merge 1 commit into from

Conversation

angerman
Copy link
Contributor

@angerman angerman commented Apr 29, 2023

Maybe the better option is:

paths:
  # trigger if the workflow changed
  - ".github/workflows/**"
  # trigger if the flake changed
  - "flake.*"
  # trigger if nix, scripts, or _sources changed
  - "nix/**"
  - "scripts/**"
  - "_sources/**"

The rational here is that PRs that don't change nay of those, should not take 10-20min CI run for what is actually wasted compute. There are no changes that influence the output of the runs.

Maybe the better option is:

```
paths:
  # trigger if the workflow changed
  - ".github/workflows/**"
  # trigger if the flake changed
  - "flake.*"
  # trigger if nix, scripts, or _sources changed
  - "nix/**"
  - "scripts/**"
  - "_sources/**"
```
@angerman angerman requested a review from a team as a code owner April 29, 2023 03:42
@michaelpj
Copy link
Contributor

This can't work, unfortunately: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/troubleshooting-required-status-checks#handling-skipped-but-required-checks

I've seen other projects use https://github.com/fkirc/skip-duplicate-actions to get around this.

I'd also just like to try and speed up the checks. The nix checks should be all cache hits in such a situation, the bottlenecks are building the repo (which also should be pretty fast), Nix evaluation, ( :( ) and uploading and downloading it as an artifact. Seee https://github.com/input-output-hk/cardano-haskell-packages/issues/165 and https://github.com/input-output-hk/cardano-haskell-packages/issues/171. Ideas welcome!

@michaelpj michaelpj closed this May 15, 2023
@angerman angerman deleted the angerman-patch-2 branch May 15, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants