Allow and add warning for HTTP anchor-data #979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Having only support for HTTPS and IPFS is cumbersome, because it would require obtaining an SSL/TLS certificate and a domain for running the tests, or publishing to IPFS with every test (whenever the anchor-data changes).
This PR allows HTTP schema but shows a warning when it is used.
It also ensures we use "scheme" throughout and not "schema" (for self-consistency and consistency with IANA nomenclature), and adds documentations for some functions.
How to trust this PR
There are plenty of tests so, in my opinion, it is mainly about documentation and code structure. I tested the warning manually, let me know if we should add an automated test for it.
Checklist