create-testnet-data: create byron genesis #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
changed the base branch from
master
to
smelc/genesis-share-writing-code
smelc
force-pushed
the
smelc/create-testnet-data-create-byron-genesis
branch
2 times, most recently
from
2072ac2 to
b984f7a
Compare
2 tasks
smelc
force-pushed
the
smelc/create-testnet-data-create-byron-genesis
branch
from
b984f7a to
10f6517
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
smelc
force-pushed
the
smelc/create-testnet-data-create-byron-genesis
branch
4 times, most recently
from
757e3e6 to
d0fe09b
Compare
smelc
force-pushed
the
smelc/create-testnet-data-create-byron-genesis
branch
from
dcbe34d to
af8d233
Compare
smelc
commented
Nov 21, 2024
Comment on lines
+2
to
+3
| byron-gen-command/genesis-keys.000.key | ||
| byron-gen-command/genesis-keys.001.key |
There was a problem hiding this comment.
Those files are not used by create-testnet-data, but they are present anyway in the workspace created by create-testnet, so I've left them in the same position.
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
carbolymer
reviewed
Nov 21, 2024
carbolymer
approved these changes
Nov 21, 2024
|
Waiting @Jimbo4350's approval before merging |
Jimbo4350
approved these changes
Nov 22, 2024
| @@ -377,7 +388,32 @@ runGenesisCreateTestNetDataCmd | |||
| stuffedUtxoAddrs | |||
| shelleyGenesis | |||
|
|
|||
| -- Write genesis.json file to output | |||
| let byronGenesisFp = outputDir </> "byron.genesis.spec.json" -- This file is used by the performance testing team. | |||
There was a problem hiding this comment.
I think this default should live in the parsers.
| byronPoolNumber = max 1 numPools -- byron genesis creation needs a >= 1 number of pools | ||
|
|
||
| -- All arbitrary values come from cardano-testnet | ||
| mkByronGenesisParameters actualNetworkWord32 byronGenesisFp shelleyGenesis = |
There was a problem hiding this comment.
All of the Byron functionality should be factored out on its own as much as possible. A separate module for it would make sense.
| mkByronGenesisParameters actualNetworkWord32 byronGenesisFp shelleyGenesis = | ||
| Byron.GenesisParameters{..} | ||
| where | ||
| gpStartTime = sgSystemStart shelleyGenesis |
There was a problem hiding this comment.
These needs comments or need to point to documentation that explains them.
| @@ -496,6 +557,37 @@ runGenesisCreateTestNetDataCmd | |||
| desiredKeyOutputFormat :: KeyOutputFormat | |||
| desiredKeyOutputFormat = KeyOutputFormatTextEnvelope | |||
|
|
|||
| -- | We need to pass these values to create the Byron genesis file. | |||
| -- The values here don't matter as the testnet conditions are ultimately determined | |||
| -- by the Shelley genesis. | |||
There was a problem hiding this comment.
Is there any documentation we can point to?
|
@Jimbo4350> created issue to follow-up on improvements: #976 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
create-testnet-databy key stakeholdersHow to trust this PR
cardano-testnetcardano-testnet: see cardano-testnet: use create-testnet-data's byron genesis generation feature cardano-node#6039Checklist