-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: release Darwin binaries #735
Conversation
35d5401
to
4d8c77a
Compare
508f7cc
to
431f9e5
Compare
431f9e5
to
bcb228e
Compare
echo "ci/hydra-build:required pending. Waiting 30s..." | ||
sleep 30;; | ||
esac | ||
conclusion=$(gh api "repos/$GITHUB_REPOSITORY/commits/${{ env.TARGET_TAG }}/check-runs" --jq '.check_runs[] | select(.name | test("ci/hydra-build:.*\\.required")) | .conclusion') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we were matching a single job, whereas now we match 3 of them; so we need a more flexible handling, hence the new lines below.
# Because we care of the newlines, quoting $conclusion with "" is especially important below! | ||
# (see https://stackoverflow.com/questions/22101778/how-to-preserve-line-breaks-when-storing-command-output-to-a-variable) | ||
|
||
# shellcheck disable=SC2126 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shellcheck wants us to use grep -c
instead of grep .. | wc -l
. The problem with grep -c
is that it fails if the number of matches is 0. We don't want that, so we keep the usage of wc -l
, but need to turn the warning off.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
This pipeline run shows an execution of this new pipeline. It was triggered like this:
It targets 1b35eec, which is one of the only commits that had the Hydra builds running (see #686 for more context).
On the considered pipeline run, you can see the new binaries being attached:
You can download the binaries and run
file
on them, you'll observe they have the expected architecture:Note that I couldn't test the tail of the pipeline (
create_release
job), because we don't have a tagged commit on which the Hydra Darwin jobs have run (yet). It's fine: we will test it when we tag the next release and I can fix the pipeline at the time, and rerun it manually (possible because it hasworkflow_dispatch
and support for targetting a commit different from the one it's being executed on).Checklist