Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration work for Node 8.7.0 #463

Merged
merged 9 commits into from
Nov 17, 2023
Merged

Integration work for Node 8.7.0 #463

merged 9 commits into from
Nov 17, 2023

Conversation

jasagredo
Copy link
Contributor

Changelog

- description: |
     Collateral inputs and the minimum value calculation are not available in the Byron era. Update the code to reflect this.
     Upgrade to `cardano-api-8.33.0.0`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR absorbs #462 and #450. Only last commit is mine

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

CarlosLopezDeLara
CarlosLopezDeLara approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both absorbed PR´s had been approved before, and the last commit from current PR looks good!

@jasagredo
Copy link
Contributor Author

Ah I just resolved one minimal git conflict and I did it wrong. Sorry

@Jimbo4350 Jimbo4350 force-pushed the jasagredo/node-8.7.0 branch from 4d7bdb5 to a8e5c29 Compare November 17, 2023 19:55
@Jimbo4350 Jimbo4350 mentioned this pull request Nov 17, 2023
Closed
3 tasks
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 5b80589 Nov 17, 2023
19 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the jasagredo/node-8.7.0 branch November 17, 2023 20:22
@jasagredo jasagredo mentioned this pull request Nov 20, 2023
Closed
3 tasks
@carlhammann carlhammann mentioned this pull request Nov 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosLopezDeLara CarlosLopezDeLara CarlosLopezDeLara approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@carbolymer carbolymer Awaiting requested review from carbolymer

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasagredo @CarlosLopezDeLara @newhoggy @Jimbo4350 @disassembler