Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put n shelley/byron key witnesses arguments in correct order #443

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

brendanrbrown
Copy link

@brendanrbrown brendanrbrown commented Nov 7, 2023

Changelog

- description: |
    Puts the `nShelleyKeyWitnesses`, `nByronKeyWitnesses` arguments to `runCalculateMinFeeCmd` in the correct order.
  type:
    - bugfix  

Context

The runCalculateMinFeeCmd swaps the number of Byron and Shelley witnesses used to calculate fees, in its call to estimateTransactionFee (see here in the function's body) of cardano-api-8.30.0.0.

The witness numbers get multiplied by a factor that differs for the Byron and Shelley eras, and the Byron multiplier is larger than the Shelley number as defined here.

So the min fee printed by runCalculateMinFeeCmd will be larger than it should be if the number of Shelley witnesses exceeds the number Byron witnesses provided.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Nov 8, 2023

Good catch! LGTM 👍

@brendanrbrown
Copy link
Author

Great, thanks. FYI I don't have merge privileges, so one of you will have to push the button.

@smelc smelc added this pull request to the merge queue Nov 8, 2023
@smelc
Copy link
Contributor

smelc commented Nov 8, 2023

FYI @Jimbo4350

Merged via the queue into IntersectMBO:main with commit 562da5e Nov 8, 2023
22 checks passed
@brendanrbrown brendanrbrown deleted the fix-calculate-min-fee-cmd branch November 8, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants