put n shelley/byron key witnesses arguments in correct order #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
The
runCalculateMinFeeCmd
swaps the number of Byron and Shelley witnesses used to calculate fees, in its call to estimateTransactionFee (see here in the function's body) ofcardano-api-8.30.0.0
.The witness numbers get multiplied by a factor that differs for the Byron and Shelley eras, and the Byron multiplier is larger than the Shelley number as defined here.
So the min fee printed by
runCalculateMinFeeCmd
will be larger than it should be if the number of Shelley witnesses exceeds the number Byron witnesses provided.Checklist