Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usages of assertFileOccurences by comparisons with golden files (3/n) #441

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 7, 2023

Changelog

- description: |
    Replace usages of assertFileOccurences by comparisons with golden files
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Observe that calls of the form assertFileOccurences _ file have been replaced with diffFileWithGoldenFile file newGoldenFile, hence doing more checks.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review November 7, 2023 11:06
@smelc smelc added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit ba858ec Nov 7, 2023
21 checks passed
@smelc smelc deleted the smelc/fix-assert-file-occurences-3 branch November 7, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants