Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration work for node 8.7.0 #440

Closed
wants to merge 8 commits into from
Closed

Integration work for node 8.7.0 #440

wants to merge 8 commits into from

Conversation

jasagredo
Copy link
Contributor

@jasagredo jasagredo commented Nov 7, 2023 •
edited
Loading

Changelog

- description: |
     Collateral inputs and the minimum value calculation are not available in the Byron era. Update the code to reflect this.
     Upgrade to `cardano-api-8.33.0.0`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This PR absorbs #462 and #450. Only last commit is mine

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@jasagredo jasagredo mentioned this pull request Nov 7, 2023
Closed
53 tasks
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch 5 times, most recently from 29374f1 to 16c4e08 Compare November 16, 2023 13:17
@Jimbo4350 Jimbo4350 force-pushed the jasagredo/node-8.7.0 branch 2 times, most recently from 6096f9f to 731816e Compare November 16, 2023 15:08
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 731816e to 8c847bc Compare November 17, 2023 16:05
@jasagredo jasagredo changed the title WIP: Integration work for node 8.7.0 Integration work for node 8.7.0 Nov 17, 2023
@jasagredo jasagredo marked this pull request as ready for review November 17, 2023 16:06
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 8c847bc to 7ca8910 Compare November 17, 2023 16:09
@jasagredo jasagredo closed this Nov 17, 2023
@jasagredo jasagredo force-pushed the jasagredo/node-8.7.0 branch from 7ca8910 to 031076f Compare November 17, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@carbolymer carbolymer Awaiting requested review from carbolymer

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasagredo @newhoggy @Jimbo4350