Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cardano-8.31.0.0 #435

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Nov 5, 2023

Changelog

- description: |
    Update to `cardano-8.31.0.0`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #388

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-8.31.0.0 branch 2 times, most recently from 91896a7 to df0b442 Compare November 10, 2023 13:58
@newhoggy newhoggy marked this pull request as ready for review November 10, 2023 13:58
@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-8.31.0.0 branch from df0b442 to f3116b2 Compare November 10, 2023 14:19
@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-8.31.0.0 branch from f3116b2 to 48b087b Compare November 10, 2023 14:23
@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-8.31.0.0 branch from 48b087b to 294cb74 Compare November 10, 2023 15:37
@newhoggy newhoggy requested review from a team as code owners November 10, 2023 15:37
hprop_roundtrip_Value_parse_renderPretty :: Property
hprop_roundtrip_Value_parse_renderPretty =
-- TODO enable these tests after switching completely to ledger types
disable_hprop_roundtrip_Value_parse_renderPretty :: Property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we enable them now?

Copy link
Contributor Author

@newhoggy newhoggy Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests fail like when Value is completely empty and the generators are now capable of generating completely empty values:

      ✗ Test.Cli.MultiAssetParsing.hprop_roundtrip_Value_parse_render failed at test/cardano-cli-test/Test/Cli/MultiAssetParsing.hs:23:5
        after 25 tests.
        shrink path: 25:
      
           ┏━━ test/cardano-cli-test/Test/Cli/MultiAssetParsing.hs ━━━
        18 ┃ hprop_roundtrip_Value_parse_render :: Property
        19 ┃ hprop_roundtrip_Value_parse_render =
        20 ┃   property $ do
        21 ┃     ledgerValue <- forAll $ genValueDefault MaryEraOnwardsConway
           ┃     │ MaryValue 0 (MultiAsset (fromList []))
        22 ┃     let value = fromLedgerValue ShelleyBasedEraConway ledgerValue
        23 ┃     tripping
           ┃     ^^^^^^^^
           ┃     │ ━━━ Original ━━━
           ┃     │ Right (valueFromList [])
           ┃     │ ━━━ Intermediate ━━━
           ┃     │ ""
           ┃     │ ━━━ Roundtrip ━━━
           ┃     │ Left (line 1, column 1):
           ┃     │ unexpected end of input
           ┃     │ expecting multi-asset value expression
        24 ┃       value
        25 ┃       renderValue
        26 ┃       (Parsec.parse parseValue "" . Text.unpack)
      
        This failure can be reproduced by running:
        > recheckAt (Seed 15168243033552485215 8658252526254707155) "25:" Test.Cli.MultiAssetParsing.hprop_roundtrip_Value_parse_render

Copy link
Contributor Author

@newhoggy newhoggy Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we particularly care about empty Value, but for completeness, I think it good if the roundtrip worked for this edge case. This can be fixed in cardano-api.

But since we're going to delete Value anyway, it probably isn't worth the effort.

In fact, I will delete these tests because they don't belong here: They test nothing in cardano-cli. See the import list for verification.

These tests should instead be moved to cardano-api.

@newhoggy newhoggy enabled auto-merge November 11, 2023 05:07
@newhoggy newhoggy added this pull request to the merge queue Nov 11, 2023
Merged via the queue into main with commit bc40e38 Nov 11, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/update-to-cardano-8.31.0.0 branch November 11, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove options from create-protocol-parameters-update
3 participants