Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden test for stake-address key-hash command #418

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mkoura
Copy link
Contributor

@mkoura mkoura commented Oct 31, 2023

Changelog

- description: |
    Add golden test for stake-address key-hash command
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@mkoura mkoura force-pushed the mkoura/add_stake_address_key_hash_test branch from 1bd6db6 to 6de5116 Compare November 1, 2023 11:17
@newhoggy newhoggy added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 43976ce Nov 1, 2023
19 checks passed
@newhoggy newhoggy deleted the mkoura/add_stake_address_key_hash_test branch November 1, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants