Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegating to always-no-confidence #403

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara commented Oct 24, 2023

Changelog

- description: |
   - Fix delegating to always no confidence default DRep
   - Add golden tests for stake address vote delegation certificates
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Resolves #402
Now it carries the corresponding [3] (it was 2)

[9, [0, h'EF1785CF18928F8353C90E76B7A8FC60855472D31A0EA1C1C774AB01'], [3]]

tests pending

How to trust this PR

              "keyHash-ef1785cf18928f8353c90e76b7a8fc60855472d31a0ea1c1c774ab01": {
                "reward": 310415375988,
                "deposit": 0,
                "ptr": [],
                "spool": "c27cf021914a2b3bcb286d3d741979083422378c577fe757702b6988",
                "drep": {
                  "tag": "DRepAlwaysNoConfidence"
                }
              }
            },

Before it was

              "keyHash-3dc96f0f04fdae3ad3c74182dfe0f720ba06c1ed2b15b78761d71290": {
                "reward": 24703004483,
                "deposit": 0,
                "ptr": [],
                "spool": "3d5e0af9fb0a82c2256faa9eb4f9db6d7b2f0af843b9e3c3dcbbfea6",
                "drep": {
                  "tag": "DRepAlwaysAbstain"
                }
              },

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as draft October 24, 2023 21:57
@CarlosLopezDeLara CarlosLopezDeLara self-assigned this Oct 25, 2023
@CarlosLopezDeLara CarlosLopezDeLara marked this pull request as ready for review October 25, 2023 08:34
@CarlosLopezDeLara CarlosLopezDeLara removed their assignment Oct 25, 2023
Copy link
Contributor

@carlhammann carlhammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Jimbo4350
Copy link
Contributor

Congrats on your first Haskell PR! 🎉

…under DRep.hs

Fix delegating to always-no-confidence

Resolves #402

Now it carries the corresponding [3]

`[9, [0, h'EF1785CF18928F8353C90E76B7A8FC60855472D31A0EA1C1C774AB01'], [3]]`

golden tests for stake address delegation certificates
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 0eeb3d8 Oct 25, 2023
19 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the cl/always-no-confidence branch October 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vote delegation to --always-no-confidence is captured as --always-abstain
5 participants