-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delegating to always-no-confidence #403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosLopezDeLara
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
October 24, 2023 21:57
carbolymer
approved these changes
Oct 25, 2023
carbolymer
reviewed
Oct 25, 2023
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/StakeAddress.hs
Show resolved
Hide resolved
carlhammann
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/StakeAddress.hs
Show resolved
Hide resolved
Jimbo4350
reviewed
Oct 25, 2023
...ano-cli/test/cardano-cli-golden/files/golden/governance/stakeaddress/alwaysAbstainDeleg.cert
Outdated
Show resolved
Hide resolved
Jimbo4350
approved these changes
Oct 25, 2023
Congrats on your first Haskell PR! 🎉 |
CarlosLopezDeLara
force-pushed
the
cl/always-no-confidence
branch
from
October 25, 2023 15:35
a386d47
to
c23f3fe
Compare
disassembler
approved these changes
Oct 25, 2023
…under DRep.hs Fix delegating to always-no-confidence Resolves #402 Now it carries the corresponding [3] `[9, [0, h'EF1785CF18928F8353C90E76B7A8FC60855472D31A0EA1C1C774AB01'], [3]]` golden tests for stake address delegation certificates
CarlosLopezDeLara
force-pushed
the
cl/always-no-confidence
branch
from
October 25, 2023 16:25
c23f3fe
to
adce798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Resolves #402
Now it carries the corresponding [3] (it was 2)
[9, [0, h'EF1785CF18928F8353C90E76B7A8FC60855472D31A0EA1C1C774AB01'], [3]]
tests pending
How to trust this PR
Before it was
Checklist