Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#213 Add check for keys permissions in the test in governance drep key-gen #401

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Add check for keys permissions in the test in governance drep key-gen
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Closes #213

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/add-check-for-permissions-in-key-gen branch 2 times, most recently from 2db6b16 to 35468fb Compare October 24, 2023 17:38
@carbolymer carbolymer marked this pull request as ready for review October 24, 2023 17:39
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-check-for-permissions-in-key-gen branch 3 times, most recently from d2e7446 to 7d79e72 Compare October 24, 2023 18:01
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but have a look at Carl's comment.

@carbolymer carbolymer force-pushed the mgalazyn/fix/add-check-for-permissions-in-key-gen branch from 11c2561 to a54eb35 Compare October 26, 2023 10:49
…y-gen

Update cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs

Co-authored-by: carlhammann <[email protected]>
@carbolymer carbolymer force-pushed the mgalazyn/fix/add-check-for-permissions-in-key-gen branch from a54eb35 to fd6ebe2 Compare October 26, 2023 10:50
@carbolymer carbolymer enabled auto-merge October 26, 2023 10:51
@carbolymer carbolymer added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit fced0aa Oct 26, 2023
@carbolymer carbolymer deleted the mgalazyn/fix/add-check-for-permissions-in-key-gen branch October 26, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DONE - User can create a delegate representative (DREP) key pair:
3 participants