Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete --utxo-cost-per-word. No longer supporting this flag in any era going forward #400

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 24, 2023

Changelog

- description: |
    Delete `--utxo-cost-per-word`.  No longer supporting this flag in any era going forward
    This include deleting the CLI option from both legacy and era-base commands
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This protocol parameter was introduced in Alonzo era and then remove immediately thereafter.

There isn't a good reason to use this protocol parameter because we can hard fork to Babbage and use --utxo-cost-per-byte instead.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/delete-ProtocolUTxOCostPerWordFeature branch from 12256c4 to 2cd9b7a Compare October 26, 2023 06:43
@newhoggy newhoggy enabled auto-merge October 26, 2023 06:50
@newhoggy newhoggy added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 2804ff1 Oct 26, 2023
@newhoggy newhoggy deleted the newhoggy/delete-ProtocolUTxOCostPerWordFeature branch October 26, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants