Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close me #399

Closed
wants to merge 1 commit into from
Closed

Close me #399

wants to merge 1 commit into from

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    <insert-changelog-description-here>
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

data PreMainnetTransactionBuildCmdArgs = TransactionBuildCmdArgs
{ nodeSocketPath :: !SocketPath
, networkId :: !NetworkId
, txins :: ![TxIn]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't fully flesh out this type but you get the idea. We're missing outputs etc.

Comment on lines +61 to +62
data PreMainnetCommand
= PreMainnetTxBuild PreMainnetTransactionBuildCmdArgs

Check notice

Code scanning / HLint

Use newtype instead of data Note

cardano-cli/src/Cardano/CLI/Run.hs:(61,1)-(62,54): Suggestion: Use newtype instead of data
  
Found:
  data PreMainnetCommand
    = PreMainnetTxBuild PreMainnetTransactionBuildCmdArgs
  
Perhaps:
  newtype PreMainnetCommand
    = PreMainnetTxBuild PreMainnetTransactionBuildCmdArgs
  
Note: decreases laziness
@Jimbo4350 Jimbo4350 closed this Oct 23, 2023
@Jimbo4350 Jimbo4350 deleted the jordan/backout-eon-related branch October 23, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant