The vote-file and proposal-file options are Conway onwards only

[newhoggy]

Changelog

- description: |
    The `vote-file` and `proposal-file` options are Conway onwards only
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Use the Featured type to declare the --vote-files and --proposal-files flags in transaction build and transaction build-raw commands should only exist from Conway era onwards.

Because TxBody also uses Featured in the same way, the code that links the CLI types to the TxBody type is streamlined.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• The change log section in the PR description has been filled in
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • round trip tests
  • integration tests
    See Running tests for more details
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• Self-reviewed the diff

[Jimbo4350]

Sorry I disagree here.

[Jimbo4350]

So we're now essentially pattern matching twice based on whether or not a feature is in an era.

[newhoggy]

Can you clarify what you mean? Is the problem the case match n the Maybe, once for voting procedures and once for proposals?

[newhoggy]

The use of inEonForEra is made unnecessary by using the Featured type.

Tidied up the code some more.

[newhoggy]

Using the new liftMaybeFeatured function to make it easy to manipulate the value within the Featured type.

readVotingProceduresFiles takes a [VoteFile In] and returns a VotingProcedures era

liftMaybeFeatured takes that computation to convert a Maybe (Featured ConwayEraOnwards [VoteFile In]) to a Maybe (Featured ConwayEraOnwards [VotingProcedures era])