Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shelley to Alonzo: add create-genesis-key-delegation-certificate to governance #368

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 11, 2023

Changelog

- description: |
    Shelley to Alonzo: add create-genesis-key-delegation-certificate to governance
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #313

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch 2 times, most recently from 7757ad1 to c1d40f8 Compare October 11, 2023 14:55
@smelc smelc marked this pull request as ready for review October 11, 2023 15:08
@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from c1d40f8 to 91c6d77 Compare October 12, 2023 07:38
@smelc
Copy link
Contributor Author

smelc commented Oct 12, 2023

cc @CarlosLopezDeLara> you may want to look at the diff of golden files to make sure this PR implements what you intended in #313.

@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from 91c6d77 to 79ce731 Compare October 12, 2023 10:12
@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from 79ce731 to f06df90 Compare October 12, 2023 12:30
@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from f06df90 to ab46e89 Compare October 12, 2023 13:24
@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from ab46e89 to c00e8af Compare October 13, 2023 09:25
@smelc
Copy link
Contributor Author

smelc commented Oct 13, 2023

Just rebased this morning, until @Jimbo4350 clarifies the way forward in this discussion.

@smelc smelc marked this pull request as draft October 13, 2023 15:32
@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch 2 times, most recently from 4eb0fdb to 12eb78f Compare October 16, 2023 08:08
@smelc smelc marked this pull request as ready for review October 16, 2023 08:10
@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from 12eb78f to c3193e6 Compare October 16, 2023 08:16
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smelc smelc force-pushed the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch from c3193e6 to f83c9d7 Compare October 16, 2023 18:05
@smelc smelc enabled auto-merge October 16, 2023 18:06
@smelc smelc added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit b83c58d Oct 16, 2023
@smelc smelc deleted the smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance branch October 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean-up cardano-cli <era> governance commands
3 participants