-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shelley to Alonzo: add create-genesis-key-delegation-certificate to governance #368
Merged
smelc
merged 3 commits into
main
from
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
Oct 16, 2023
Merged
Shelley to Alonzo: add create-genesis-key-delegation-certificate to governance #368
smelc
merged 3 commits into
main
from
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
2 times, most recently
from
October 11, 2023 14:55
7757ad1
to
c1d40f8
Compare
3 tasks
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
October 11, 2023 15:08
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 12, 2023 07:38
c1d40f8
to
91c6d77
Compare
cc @CarlosLopezDeLara> you may want to look at the diff of golden files to make sure this PR implements what you intended in #313. |
newhoggy
reviewed
Oct 12, 2023
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/GenesisKeyDelegationCertificate.hs
Outdated
Show resolved
Hide resolved
newhoggy
approved these changes
Oct 12, 2023
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 12, 2023 10:12
91c6d77
to
79ce731
Compare
newhoggy
reviewed
Oct 12, 2023
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/GenesisKeyDelegationCertificate.hs
Outdated
Show resolved
Hide resolved
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 12, 2023 12:30
79ce731
to
f06df90
Compare
Jimbo4350
reviewed
Oct 12, 2023
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/GenesisKeyDelegationCertificate.hs
Outdated
Show resolved
Hide resolved
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 12, 2023 13:24
f06df90
to
ab46e89
Compare
Jimbo4350
requested changes
Oct 12, 2023
cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/GenesisKeyDelegationCertificate.hs
Outdated
Show resolved
Hide resolved
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 13, 2023 09:25
ab46e89
to
c00e8af
Compare
Just rebased this morning, until @Jimbo4350 clarifies the way forward in this discussion. |
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
2 times, most recently
from
October 16, 2023 08:08
4eb0fdb
to
12eb78f
Compare
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 16, 2023 08:16
12eb78f
to
c3193e6
Compare
Jimbo4350
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
...cli-golden/files/golden/help/legacy_governance_create-genesis-key-delegation-certificate.cli
Show resolved
Hide resolved
smelc
force-pushed
the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
from
October 16, 2023 18:05
c3193e6
to
f83c9d7
Compare
smelc
deleted the
smelc/shelley-to-alonzo-move-create-genesis-key-delegation-certificate-to-governance
branch
October 16, 2023 18:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Fixes #313
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7