Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for committee hot key witnesses #338

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 5, 2023

Changelog

- description: |
    Add support for committee hot key witnesses
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Depends on IntersectMBO/cardano-api#300

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 5, 2023 11:47
@newhoggy newhoggy force-pushed the newhoggy/add-support-for-committee-hot-key-witnesses branch from 6ef28ec to 1b8c228 Compare October 5, 2023 11:48
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/add-support-for-committee-hot-key-witnesses branch from 1ee3c0d to a58ed72 Compare October 5, 2023 19:10
@Jimbo4350 Jimbo4350 force-pushed the newhoggy/add-support-for-committee-hot-key-witnesses branch from a58ed72 to ff5a44f Compare October 5, 2023 19:13
@newhoggy newhoggy requested review from a team as code owners October 5, 2023 19:38
@disassembler disassembler force-pushed the newhoggy/add-support-for-committee-hot-key-witnesses branch from 5c5ac20 to 4df9418 Compare October 5, 2023 20:00
@Jimbo4350 Jimbo4350 merged commit 3d47a18 into main Oct 5, 2023
18 checks passed
@Jimbo4350 Jimbo4350 deleted the newhoggy/add-support-for-committee-hot-key-witnesses branch October 5, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants