Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cardano-api-8.23.1.0 #321

Closed
wants to merge 1 commit into from

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 1, 2023

Changelog

- description: |
    Update to `cardano-api-8.23.1.0`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 1, 2023 23:04
@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-api-8.23.1.0 branch from 8d0798a to 3559732 Compare October 1, 2023 23:45
@newhoggy newhoggy requested review from a team as code owners October 1, 2023 23:45
@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-api-8.23.1.0 branch from 3559732 to 0a978b0 Compare October 1, 2023 23:49
@newhoggy newhoggy force-pushed the newhoggy/update-to-cardano-api-8.23.1.0 branch from 0a978b0 to 5cc2922 Compare October 2, 2023 00:35
@newhoggy
Copy link
Contributor Author

newhoggy commented Oct 2, 2023

Closing in favour of #320

@newhoggy newhoggy closed this Oct 2, 2023
@carbolymer carbolymer deleted the newhoggy/update-to-cardano-api-8.23.1.0 branch October 2, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant