Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drep registration-certificate: remove mix with SPO registration #309

Merged
merged 9 commits into from
Sep 29, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Sep 27, 2023

Changelog

- description: |
    - Remove SPO registration bits from drep registration-certificate command
    - Remove drep command from eras before Conway
    - Remove `AnyRegistrationTarget`
    - Remove `RegistrationTarget`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/untangle-drep-reg-from-spo-reg branch from f1a9e72 to 93004e5 Compare September 27, 2023 09:00
@smelc
Copy link
Contributor Author

smelc commented Sep 27, 2023

As of the current tip, the API of drep registration-certificate is as follows:

Usage: cardano-cli conway governance drep registration-certificate 
                                                                     ( --drep-verification-key STRING
                                                                     | --drep-verification-key-file FILE
                                                                     | --drep-key-hash HASH
                                                                     )
                                                                     --key-reg-deposit-amt NATURAL
                                                                     --out-file FILE

  Create a registration certificate.

Available options:
  --drep-verification-key STRING
                           DRep verification key (Bech32 or hex-encoded).
  --drep-verification-key-file FILE
                           Filepath of the DRep verification key.
  --drep-key-hash HASH     DRep verification key hash (either Bech32-encoded or
                           hex-encoded). Zero or more occurences of this option
                           is allowed.
  --key-reg-deposit-amt NATURAL
                           Key registration deposit amount.
  --out-file FILE          The output file.
  -h,--help                Show this help text

@smelc smelc force-pushed the smelc/untangle-drep-reg-from-spo-reg branch 3 times, most recently from c6c7de1 to f9cbcdd Compare September 27, 2023 13:11
@smelc smelc marked this pull request as ready for review September 27, 2023 14:36
@smelc smelc force-pushed the smelc/untangle-drep-reg-from-spo-reg branch from 45bb5e5 to 45767f3 Compare September 29, 2023 08:08
@smelc
Copy link
Contributor Author

smelc commented Sep 29, 2023

Follow-up PR will be required after #198 (comment) is tackled

@smelc smelc added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit b8f820b Sep 29, 2023
19 checks passed
@smelc smelc deleted the smelc/untangle-drep-reg-from-spo-reg branch September 29, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants