Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing redeemers in certificate delegation and deregistration #306

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix missing redeemers in certificate delegation and deregistration #306

merged 1 commit into from
Oct 4, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 25, 2023 •
edited
Loading

Changelog

- description: |
    Fix missing redeemers in certificate delegation and deregistration
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires:

Fixes:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer mentioned this pull request Sep 25, 2023
Merged
10 tasks
@carbolymer carbolymer force-pushed the mgalazyn/fix/missing-redeemers-when-sending-transaction branch 10 times, most recently from d258d0f to 1c1074a Compare September 27, 2023 13:40
@carbolymer carbolymer force-pushed the mgalazyn/fix/missing-redeemers-when-sending-transaction branch 5 times, most recently from 6da1cee to fd5cf2a Compare September 29, 2023 19:11
@carbolymer
Copy link
Contributor Author

carbolymer commented Sep 29, 2023 •
edited
Loading

This PR is not building, because it requires patterns exports available in cardano-api-8.23, which is introduced in: #320

@carbolymer carbolymer marked this pull request as ready for review September 29, 2023 19:12
@carbolymer carbolymer force-pushed the mgalazyn/fix/missing-redeemers-when-sending-transaction branch from fd5cf2a to 945cb67 Compare September 29, 2023 19:22
Jimbo4350
Jimbo4350 requested changes Oct 2, 2023
View reviewed changes
cardano-cli/src/Cardano/CLI/Types/Errors/TxValidationError.hs
@@ -1,5 +1,3 @@
{-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cardano-cli/src/Cardano/CLI/Types/Errors/TxValidationError.hs
-> Maybe StakeCredential
deriveStakeCredentialWitness = fmap fromShelleyStakeCredential . \case
ShelleyRelatedCertificate stbEra shelleyCert -> shelleyToBabbageEraConstraints stbEra $
case shelleyCert of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have this function in cardano-api?

Copy link
Contributor Author

@carbolymer carbolymer Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are similar ones, but are not the same: https://github.com/input-output-hk/cardano-api/blob/151eff181cb1782f9db46dbea36d22e8d40f0545/cardano-api/internal/Cardano/Api/Certificate.hs#L670

Should we extract stake creds only for deregistration and delegation like the comment says here, or should we use stake credential witness for the cases when it's available?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it as it for now. We should follow the specification and document it here

@carbolymer carbolymer force-pushed the mgalazyn/fix/missing-redeemers-when-sending-transaction branch from 945cb67 to 28d2f35 Compare October 3, 2023 09:08
@carbolymer carbolymer force-pushed the mgalazyn/fix/missing-redeemers-when-sending-transaction branch from 28d2f35 to 99e3ae7 Compare October 3, 2023 11:09
@newhoggy newhoggy added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 4742afb Oct 4, 2023
19 checks passed
@newhoggy newhoggy deleted the mgalazyn/fix/missing-redeemers-when-sending-transaction branch October 4, 2023 13:36
@mkoura mkoura mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carbolymer @Jimbo4350 @newhoggy