-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to cardano-api-8.21.0.0 #304
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -157,7 +157,7 @@ txSpendGenesisUTxOByronPBFT gc nId sk (ByronAddress bAddr) outs = do | |
, txOuts = outs | ||
, txTotalCollateral = TxTotalCollateralNone | ||
, txReturnCollateral = TxReturnCollateralNone | ||
, txFee = TxFeeImplicit TxFeesImplicitInByronEra | ||
, txFee = TxFeeImplicit ByronEraOnlyByron | ||
, txValidityRange = | ||
( TxValidityNoLowerBound | ||
, TxValidityNoUpperBound ValidityNoUpperBoundInByronEra | ||
|
@@ -206,7 +206,7 @@ txSpendUTxOByronPBFT nId sk txIns outs = do | |
, txOuts = outs | ||
, txTotalCollateral = TxTotalCollateralNone | ||
, txReturnCollateral = TxReturnCollateralNone | ||
, txFee = TxFeeImplicit TxFeesImplicitInByronEra | ||
, txFee = TxFeeImplicit ByronEraOnlyByron | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can do that. I'll put a PR to remove the era suffix for all the |
||
, txValidityRange = | ||
( TxValidityNoLowerBound | ||
, TxValidityNoUpperBound ValidityNoUpperBoundInByronEra | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ pGovernanceCmds era envCli = | |
|
||
pCreateMirCertificatesCmds :: CardanoEra era -> Maybe (Parser (GovernanceCmds era)) | ||
pCreateMirCertificatesCmds era = do | ||
w <- maybeFeatureInEra era | ||
w <- maybeEonInEra era | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to rethink these names. They are confusing. |
||
pure | ||
$ subParser "create-mir-certificate" | ||
$ Opt.info (pMIRPayStakeAddresses w <|> mirCertParsers w) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍