Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write descriptions in out files when generating non-extended keys, for all kinds of supported keys #413

Closed
smelc opened this issue Oct 31, 2023 · 0 comments · Fixed by #416
Closed

Write descriptions in out files when generating non-extended keys, for all kinds of supported keys #413

smelc opened this issue Oct 31, 2023 · 0 comments · Fixed by #416
Assignees
@smelc
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smelc
Copy link
Contributor

smelc commented Oct 31, 2023 •
edited
Loading

I made the constant a top-level symbol of Cardano.CLI.EraBased.Run.Key and reused it from Governance. I looked around but saw no obvious destinations and didn't want to introduce a Constant module.

I also propose to put descriptions when converting other types of extended keys, but will do that in another PR, to avoid delaying this one.

Originally posted by @smelc in #377 (comment)
@smelc smelc self-assigned this Oct 31, 2023
@smelc smelc changed the title Provide descriptions when generating non-extended keys Write descriptions in out files when generating non-extended keys, for all kinds of supported keys Oct 31, 2023
@smelc smelc added enhancement New feature or request good first issue Good for newcomers labels Oct 31, 2023
@smelc smelc mentioned this issue Oct 31, 2023
Merged
3 tasks
@smelc smelc closed this as completed in #416 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smelc smelc

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extended to non-extended key: write description field in all cases IntersectMBO/cardano-cli
1 participant
@smelc