governance action create-new-committee NOT WORKING

[CarlosLopezDeLara]

1. It needs to be updated to take cc-keys (it was first implemented with stake credentials to make some progress while we had cc keys)
2. The flags need to be uniquely prefixed i.e. ---old-cc-key --new-cc-key otherwise the parser fails.

Usage: cardano-cli conway governance action create-new-committee
                                                                   ( --mainnet
                                                                   | --testnet
                                                                   )
                                                                   --governance-action-deposit NATURAL
                                                                   ( --stake-pool-verification-key STRING
                                                                   | --cold-verification-key-file FILE
                                                                   | --stake-pool-id STAKE_POOL_ID
                                                                   | --stake-verification-key STRING
                                                                   | --stake-verification-key-file FILE
                                                                   | --stake-key-hash HASH
                                                                   )
                                                                   --proposal-url TEXT
                                                                   ( --proposal-text TEXT
                                                                   | --proposal-file FILE
                                                                   | --proposal-hash HASH
                                                                   )
                                                                   [ --stake-pool-verification-key STRING
                                                                   | --cold-verification-key-file FILE
                                                                   | --stake-pool-id STAKE_POOL_ID
                                                                   | --stake-verification-key STRING
                                                                   | --stake-verification-key-file FILE
                                                                   | --stake-key-hash HASH
                                                                   ]
                                                                   [
                                                                     ( --stake-pool-verification-key STRING
                                                                     | --cold-verification-key-file FILE
                                                                     | --stake-pool-id STAKE_POOL_ID
                                                                     | --stake-verification-key STRING
                                                                     | --stake-verification-key-file FILE
                                                                     | --stake-key-hash HASH
                                                                     )
                                                                     --epoch NATURAL]
                                                                   --quorum RATIONAL
                                                                   [--governance-action-tx-id TXID
                                                                     --governance-action-index WORD32]
                                                                   --out-file FILE

It needs to take cc keys instead of stake keys

Usage: cardano-cli conway governance action create-new-committee
                                                                   ( --mainnet
                                                                   | --testnet
                                                                   )
                                                                   --governance-action-deposit NATURAL
                                                                   ( --stake-pool-verification-key STRING
                                                                   | --cold-verification-key-file FILE
                                                                   | --stake-pool-id STAKE_POOL_ID
                                                                   | --stake-verification-key STRING
                                                                   | --stake-verification-key-file FILE
                                                                   | --stake-key-hash HASH
                                                                   )
                                                                   --proposal-url TEXT
                                                                   ( --proposal-text TEXT
                                                                   | --proposal-file FILE
                                                                   | --proposal-hash HASH
                                                                   )
                                                                   [ --remove-cc-verification-key STRING
                                                                   | --remove-cc-verification-key-file FILE
                                                                   | --remove-cc-key-hash HASH
                                                                   ]
                                                                   [
                                                                     ( --add-cc-verification-key STRING
                                                                     | --add-cc-verification-key-file FILE
                                                                     | --add-cc-key-hash HASH
                                                                     )
                                                                     --epoch NATURAL]
                                                                   --new-quorum RATIONAL
                                                                   [--governance-action-tx-id TXID
                                                                     --governance-action-index WORD32]
                                                                   --out-file FILE

[smelc]

Repasting @CarlosLopezDeLara's follow-up from Slack:

All right!! so parsing issue is resolved (merged the PR) now it's time to address the credentials allowed here.

~ cardano-cli conway governance action create-new-committee \
--testnet \
--governance-action-deposit 0 \
--stake-verification-key-file example/utxo-keys/stake1.vkey \
--proposal-url https://shorturl.at/asIJ6 \
--proposal-file example/cc/cc_proposal.txt \
--add-cc-stake-verification-key-file example/cc/cold1-cc.vkey \
--epoch 110 \
--quorum 50/100 \
--out-file example/cc/new-committee.action

Command failed: governance action create-new-committee  Error: Cannot read file: example/cc/cold1-cc.vkey: TextEnvelope type error:  Expected: StakeVerificationKeyShelley_ed25519 Actual: ConstitutionalCommitteeColdVerificationKey_ed25519

We don't need stake credentials or stake pool credentials, we should only take Constitutional Committee Keys. Something like

[ --remove-cc-verification-key STRING
| --remove-cc-verification-key-file FILE
| --remove-cc-key-hash HASH
]
[
    ( --add-cc-verification-key STRING
    | --add-cc-verification-key-file FILE
    | --add-cc-key-hash HASH
    )
]

And perhaps just explain on the help that it is about the COLD CREDENTIALS (not the Hot ones)

[ --remove-cc-verification-key STRING         COLD verification key of the CC member to remove
| --remove-cc-verification-key-file FILE      COLD verification key file of the CC member to remove
| --remove-cc-key-hash HASH                   COLD verification key hash of the CC member to remove
]
[
    ( --add-cc-verification-key STRING        COLD verification key of the proposed new CC member
    | --add-cc-verification-key-file FILE     COLD verification key file of the proposed new CC member
    | --add-cc-key-hash HASH                  COLD verification key hash of the proposed new CC member
    )
]

[CarlosLopezDeLara]

resolved by #304 and #302