Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ProtocolParameters #729

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 16, 2025

Changelog

- description: |
    Remove the ProtocolParameters type, that has been deprecated for a while
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

ProtocolParameters had been deprecated in favor the ledger's PParams type. We are now removing ProtocolParameters altogether.

Fixes #384

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Jan 28, 2025

This is blocked on merging IntersectMBO/cardano-node#6090 in cardano-node so this is going to stay in draft a little while. The performance team has been notified of 6090, but needs to act on stopping to support Byron to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate cardano-api's ProtocolParameters
1 participant