Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the Convert class #696

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Export the Convert class #696

merged 1 commit into from
Nov 28, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 27, 2024

Changelog

- description: |
    Export the Convert class
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

#690 overlooked exporting the new Convert class. This PR fixes this.

How to trust this PR

It's just an additional export

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas
Copy link
Contributor

palas commented Nov 27, 2024

Why expose it in two places though? (Cardano.Api seems to be importing it directly)

@smelc
Copy link
Contributor Author

smelc commented Nov 28, 2024

Why expose it in two places though? (Cardano.Api seems to be importing it directly)

@palas> yeah I wondered too if this was correct, but Inject was handled like this, so I chose to stay consistent with it 👍

@smelc smelc force-pushed the smelc/export-convert branch from 8fe5fa1 to f0350e3 Compare November 28, 2024 09:25
@smelc smelc enabled auto-merge November 28, 2024 09:25
@smelc smelc added this pull request to the merge queue Nov 28, 2024
Merged via the queue into master with commit 997122e Nov 28, 2024
29 checks passed
@smelc smelc deleted the smelc/export-convert branch November 28, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants