Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EraTxWits, TxDats, and functions for converting datums and scripts to JSON #689

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Nov 25, 2024

Changelog

- description: |
    Exposed `Language`, `Plutus`, `Script`, `getNativeScript`, `languageToText`, `plutusBinary`, `plutusScriptLanguage`, `serializeAsHexText`, `showTimelock` in `Cardano.Api.Ledger`, and `AlonzoEraOnwardsConstraints` in `Cardano.Api`
  type:
  - feature

Context

friendlyTxBodyImpl wasn't exposing information about datums nor redeemers. In order to address that, it is necessary to expose types through the cardano-api to be used by cardano-cli.

How to trust this PR

I would look at the structure of the JSON that is generated mainly, and check whether the functions and types are exported in the right places. Also probably good to look at this PR in conjunction with IntersectMBO/cardano-cli#977

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Nov 25, 2024
@palas palas self-assigned this Nov 25, 2024
@palas palas changed the title Expose EraTxWits, TxDats, an functions for converting datums and scripts to JSON Expose EraTxWits, TxDats, and functions for converting datums and scripts to JSON Nov 25, 2024
@palas palas force-pushed the expose-era-tx-wits branch from 2ddebb6 to 72a82e2 Compare November 27, 2024 18:09
@palas palas added this pull request to the merge queue Nov 28, 2024
Merged via the queue into master with commit a8446e7 Nov 28, 2024
25 checks passed
@palas palas deleted the expose-era-tx-wits branch November 28, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants