Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using of absolute paths in prettify script #621

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Fix using of absolute paths in prettify script
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/fix-prettify-with-absolute-paths branch from 054f646 to 2c8c20d Compare August 23, 2024 15:33
@carbolymer carbolymer requested a review from a team as a code owner August 23, 2024 15:33
@carbolymer carbolymer force-pushed the mgalazyn/chore/fix-prettify-with-absolute-paths branch from 2c8c20d to a70b647 Compare August 23, 2024 15:43
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about skipping files containing CPP?

@carbolymer
Copy link
Contributor Author

@Jimbo4350 it's done in prettify itself already, so there was no point in duplicating the logic. You can see it in the CI output: https://github.com/IntersectMBO/cardano-api/actions/runs/10528514101/job/29174180469?pr=621#step:5:23

@carbolymer carbolymer added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 861fb11 Aug 23, 2024
25 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/fix-prettify-with-absolute-paths branch August 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants