Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IsList(toList,fromList) instead of specialised functions #609

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Use `IsList(toList,fromList)` instead of specialised functions
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

That's a follow-up from #603 , where some references to concrete collections' fromList & toList were still left in the codebase.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/refactor/use-islist branch from 7e9fcb7 to 0d3efb4 Compare August 6, 2024 14:46
@carbolymer carbolymer marked this pull request as ready for review August 6, 2024 14:47
@carbolymer carbolymer enabled auto-merge August 6, 2024 15:01
@carbolymer carbolymer added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit cd4bc80 Aug 6, 2024
28 checks passed
@carbolymer carbolymer deleted the mgalazyn/refactor/use-islist branch August 6, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants