Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cabal-gild and update hook #578

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Add cabal-gild and update hook #578

merged 1 commit into from
Jul 5, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 3, 2024

Changelog

- description: |
    Added cabal-gild to dev shell, to haskell-style-lint hook script, and created CI action to check it.
  type:
    - maintenance

Context

We don't want to have to worry about the formatting of .cabal files, and we want it to be consistent. This PR tries to address this.

How to trust this PR

Probably check that the hook works for you. Also that you are happy with the changes and configuration, and that the CI passes.

I've also checked that it doesn't pass when the cabal file is modified and unformatted. See:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the test Adding or reworking tests label Jul 3, 2024
@palas palas self-assigned this Jul 3, 2024
@palas palas force-pushed the add-cabal-gild branch 7 times, most recently from ef0ce77 to 35e6823 Compare July 3, 2024 23:32
.github/workflows/check-cabal-gild.yml Outdated Show resolved Hide resolved
.github/workflows/check-cabal-gild.yml Outdated Show resolved Hide resolved
.github/workflows/check-cabal-gild.yml Outdated Show resolved Hide resolved
.github/workflows/check-cabal-gild.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking on misaligned comments in the cabal file.

.github/workflows/check-cabal-gild.yml Show resolved Hide resolved
.github/workflows/check-cabal-gild.yml Show resolved Hide resolved
cardano-api/cardano-api.cabal Show resolved Hide resolved
cardano-api/cardano-api.cabal Outdated Show resolved Hide resolved
cardano-api/cardano-api.cabal Outdated Show resolved Hide resolved
@palas palas force-pushed the add-cabal-gild branch 2 times, most recently from b86586c to 252755a Compare July 4, 2024 15:34
cardano-api/cardano-api.cabal Outdated Show resolved Hide resolved
Co-authored-by: Clément Hurlin <[email protected]>
@palas palas force-pushed the add-cabal-gild branch from 252755a to 0332813 Compare July 5, 2024 15:43
@palas palas requested a review from carbolymer July 5, 2024 15:44
@palas palas dismissed carbolymer’s stale review July 5, 2024 16:47

Reason for block addressed

@palas palas added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 0c3c7af Jul 5, 2024
24 checks passed
@palas palas deleted the add-cabal-gild branch July 5, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding or reworking tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants