-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cabal-gild and update hook #578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
a team,
dcoutts,
erikd,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
July 3, 2024 17:01
palas
force-pushed
the
add-cabal-gild
branch
7 times, most recently
from
July 3, 2024 23:32
ef0ce77
to
35e6823
Compare
smelc
reviewed
Jul 4, 2024
carbolymer
previously requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on misaligned comments in the cabal file.
palas
force-pushed
the
add-cabal-gild
branch
2 times, most recently
from
July 4, 2024 15:34
b86586c
to
252755a
Compare
Jimbo4350
approved these changes
Jul 5, 2024
Co-authored-by: Clément Hurlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
We don't want to have to worry about the formatting of
.cabal
files, and we want it to be consistent. This PR tries to address this.How to trust this PR
Probably check that the hook works for you. Also that you are happy with the changes and configuration, and that the CI passes.
I've also checked that it doesn't pass when the cabal file is modified and unformatted. See:
Checklist