Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable simd on bitvec dependency #554

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Disable simd on bitvec dependency #554

merged 1 commit into from
Jun 17, 2024

Conversation

angerman
Copy link
Contributor

@angerman angerman commented Jun 14, 2024

This should hopefully make errors like the following go away (until we have the linker/loader for w32 fixed for c++ dependencies):

008c:err:setupapi:SetupDefaultQueueCallbackW copy error 1812 L"@C:\\windows\\system32\\drivers\\wineusb.sys,-1" -> L"C:\\windows\\inf\\wineusb.inf"
wine: failed to open L"C:\\windows\\syswow64\\rundll32.exe": c0000135
wine: configuration in L"/build" has been updated.
Listening on port 7200
iserv-proxy-interpreter.exe:|/nix/store/wi52hmyajdncvx8yhkyrwc6phq0cj3dw-bitv
ec-lib-bitvec-x86_64-w64-mingw32-1.1.5.0/lib/x86_64-windows-ghc-9.6.4/bitvec-1.1
.5.0-CuwZlpVmbRn6Ve35hpelj8/HSbitvec-1.1.5.0-CuwZlpVmbRn6Ve35hpelj8.o:unknown s
ymbol`__cpu_model'
iserv-proxy-interpreter.exe:CouldnotloadObjectCode/nix/store/wi52hmyajdncv
x8yhkyrwc6phq0cj3dw-bitvec-lib-bitvec-x86_64-w64-mingw32-1.1.5.0/lib/x86_64-wind
ows-ghc-9.6.4/bitvec-1.1.5.0-CuwZlpVmbRn6Ve35hpelj8/HSbitvec-1.1.5.0-CuwZlpVmbRn
6Ve35hpelj8.o.


<no location info>: error: unable to load unit `bitvec-1.1.5.0'
[ 17 of 186] Compiling PlutusCore.Pretty.ConfigName ( plutus-core/src/PlutusCore/Pretty/ConfigName.hs, dist/build/PlutusCore/Pretty/ConfigName.o )
[ 18 of 186] Compiling PlutusPrelude    ( prelude/PlutusPrelude.hs, dist/build/PlutusPrelude.o )
[ 19 of 186] Compiling PlutusCore.Version ( plutus-core/src/PlutusCore/Version.hs, dist/build/PlutusCore/Version.o )
0024:err:seh:call_stack_handlers invalid frame 00007FFFFF662F60 (0000000000022000-0000000000220000)
0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception.
iserv-proxy: {handle: <socket: 6>}: GHCi.Message.remoteCall: end of file

<no location info>: error: ghc-iserv terminated (1)

Changelog

- description: |
    disable c++ nonsense on bitvec, to make it compile. Required because the windows linker/loader chokes on c++ dependencies.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

This should hopefully make errors like the following go away (until we have the linker/loader for w32 fixed for c++ dependencies):

```
008c:err:setupapi:SetupDefaultQueueCallbackW copy error 1812 L"@C:\\windows\\system32\\drivers\\wineusb.sys,-1" -> L"C:\\windows\\inf\\wineusb.inf"
wine: failed to open L"C:\\windows\\syswow64\\rundll32.exe": c0000135
wine: configuration in L"/build" has been updated.
Listening on port 7200
iserv-proxy-interpreter.exe:|/nix/store/wi52hmyajdncvx8yhkyrwc6phq0cj3dw-bitv
ec-lib-bitvec-x86_64-w64-mingw32-1.1.5.0/lib/x86_64-windows-ghc-9.6.4/bitvec-1.1
.5.0-CuwZlpVmbRn6Ve35hpelj8/HSbitvec-1.1.5.0-CuwZlpVmbRn6Ve35hpelj8.o:unknown s
ymbol`__cpu_model'
iserv-proxy-interpreter.exe:CouldnotloadObjectCode/nix/store/wi52hmyajdncv
x8yhkyrwc6phq0cj3dw-bitvec-lib-bitvec-x86_64-w64-mingw32-1.1.5.0/lib/x86_64-wind
ows-ghc-9.6.4/bitvec-1.1.5.0-CuwZlpVmbRn6Ve35hpelj8/HSbitvec-1.1.5.0-CuwZlpVmbRn
6Ve35hpelj8.o.


<no location info>: error: unable to load unit `bitvec-1.1.5.0'
[ 17 of 186] Compiling PlutusCore.Pretty.ConfigName ( plutus-core/src/PlutusCore/Pretty/ConfigName.hs, dist/build/PlutusCore/Pretty/ConfigName.o )
[ 18 of 186] Compiling PlutusPrelude    ( prelude/PlutusPrelude.hs, dist/build/PlutusPrelude.o )
[ 19 of 186] Compiling PlutusCore.Version ( plutus-core/src/PlutusCore/Version.hs, dist/build/PlutusCore/Version.o )
0024:err:seh:call_stack_handlers invalid frame 00007FFFFF662F60 (0000000000022000-0000000000220000)
0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception.
iserv-proxy: {handle: <socket: 6>}: GHCi.Message.remoteCall: end of file

<no location info>: error: ghc-iserv terminated (1)
```
@smelc smelc added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit bd58f07 Jun 17, 2024
23 of 25 checks passed
@smelc smelc deleted the angerman/bitvec-simd branch June 17, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants