Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell.yml: remove useless steps: artifacts production #553

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jun 13, 2024

Changelog

- description: |
    haskell.yml: remove useless steps: artifacts production
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

We have two steps in the CI that:

  1. Builds an archive with the executables produced by the build
  2. Save this archive as a GitHub artifact

But we have no executable produced during our build, so those steps are useless. You can see that in the last PR that was merged:

https://github.com/IntersectMBO/cardano-api/actions/runs/9500405626/job/26183389287?pr=448

Look at the considered steps, that mention they are useless:

image

How to trust this PR

  • CI still passes
  • It's only deletions

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc requested review from Jimbo4350, newhoggy, carbolymer, palas and a team as code owners June 13, 2024 14:15
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@smelc smelc merged commit 833e8c0 into main Jun 14, 2024
22 of 32 checks passed
@smelc smelc deleted the smelc/ci-remove-artifacts-saving branch June 14, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants