Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newhoggy/document gadt constructor arguments 2 #541

Closed
wants to merge 2 commits into from

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    <insert-changelog-description-here>
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/document-gadt-constructor-arguments-2 branch from 7a4a358 to a6d96b4 Compare May 22, 2024 13:18
@newhoggy newhoggy force-pushed the newhoggy/document-gadt-constructor-arguments-2 branch from a6d96b4 to 8f4e2f6 Compare May 22, 2024 13:19
@@ -2,8 +2,6 @@ name: "Haddock documentation"

on:
push:
branches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is quite time consuming, so we should not enable it on every push. I wanted to revisit the pipelines and caching after #437

@@ -46,7 +46,7 @@

# see flake `variants` below for alternative compilers
defaultCompiler = "ghc964";
haddockShellCompiler = defaultCompiler;
haddockShellCompiler = "ghc8107";
Copy link
Contributor

@carbolymer carbolymer May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use GHC 9.6? Which haddock version will be used then? I think we needed fairly recent one for cabal project haddock to work.

Copy link

github-actions bot commented Jul 8, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jul 8, 2024
Copy link

github-actions bot commented Sep 6, 2024

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants