-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new query for a snapshot of big ledger peers #521
base: master
Are you sure you want to change the base?
Conversation
eedaa47
to
e50a5e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thanks. Few comments to make sure that this PR adheres to the conventions used here.
There are build failures too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, not blocking changes if this query is for eras >= Shelley.
e50a5e7
to
12e01d7
Compare
fef7482
to
46d8908
Compare
1cb28c9
to
bd4afe0
Compare
FYI: Because we now enforce the use of |
FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch here: backup/mwojtowicz/query-ledger-peer-snapshot |
e799c03
to
84398c4
Compare
2fcd02e
to
c948d05
Compare
c948d05
to
235849b
Compare
This PR is stale because it has been open 45 days with no activity. |
6b6eb32
to
708c91b
Compare
9f97741
to
64bdc19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you test e2e (with cardano-cli changes) if the query works, before merging?
@@ -52,3 +52,14 @@ write-ghc-environment-files: always | |||
constraints: | |||
Cabal < 3.14, | |||
cardano-ledger-shelley ^>= 1.14.1 | |||
|
|||
source-repository-package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SRP needs to be removed before merge.
640fa39
to
24a15fd
Compare
This change introduces a new query tag and handler to support retrieval of a snapshot of big ledger peers from the current tip of a node.
24a15fd
to
a8ee0d7
Compare
a8ee0d7
to
ed59e98
Compare
This change introduces a new query tag and handler to support retrieval of a snapshot of big ledger peers from the current tip of a node.
Changelog
Context
A snapshot of big ledger peers is very useful when bootstrapping a node from scratch in the upcoming Genesis consensus mode. Since only some, or none, of these peers are available to a node from its own ledger when syncing up, a snapshot is a means of providing these relays to the diffusion layer to ensure that a node ends up on a good chain.
Checklist