-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for invalid-before and invalid-here-after in eras up to Alonzo
#408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the direction we are going in however I want to see how my new abstraction works in the cli first. After I make a small PR there we can revisit this PR and make a sweeping change, rather than breaking the api now and then potentially again in the near future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the above in mind I want to see if its possible to not break the existing api at all for the time being and introduce the new api alongside the existing api. The wallet team will (rightly) be very annoyed if we make them go through two breaking changes one afeter the other. I need to explore the smoothest transition possible and we can use the cli as a first trial.
This PR is stale because it has been open 45 days with no activity. |
…txout_test Add golden test for creating TxOut with inline datum
This PR is stale because it has been open 45 days with no activity. |
This issue was closed because it has been stalled for 60 days with no activity. |
Changelog
Context
Removing support for features in era up to Alonzo simplifies the code a lot.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist