Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for invalid-before and invalid-here-after in eras up to Alonzo #408

Closed
wants to merge 5 commits into from

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Dec 19, 2023

Changelog

- description: |
    * No support for invalid-before and invalid-here-after in eras up to `Alonzo`
    * No support for tx-aux-scripts in eras up to `Alonzo`
    * `invalidBeforeTxBodyL` now takes `BabbageEraOnwards` instead of `AllegraEraOnwards`.
    * `TxValidityLowerBound` constructor takes `BabbageEraOnwards` instead of `AllegraEraOnwards`.
    * `TxAuxScripts` constructor takes  `BabbageEraOnwards` instead of `AllegraEraOnwards`.
    * Delete `ShelleyEraOnly` and `AllegeraEraOnwards` and associated functions.
    * Modify `TxValidityUpperBound` constructor to take `BabbageEraOnwards` instead of `ShelleyBasedEra` and remove the `Maybe`.
    * Introduce `TxValidityNoUpperBound` constructor 
    
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Removing support for features in era up to Alonzo simplifies the code a lot.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review December 19, 2023 14:02
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the direction we are going in however I want to see how my new abstraction works in the cli first. After I make a small PR there we can revisit this PR and make a sweeping change, rather than breaking the api now and then potentially again in the near future.

@Jimbo4350 Jimbo4350 self-requested a review December 19, 2023 19:15
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the above in mind I want to see if its possible to not break the existing api at all for the time being and introduce the new api alongside the existing api. The wallet team will (rightly) be very annoyed if we make them go through two breaking changes one afeter the other. I need to explore the smoothest transition possible and we can use the cli as a first trial.

Copy link

github-actions bot commented Feb 3, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Feb 3, 2024
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…txout_test

Add golden test for creating TxOut with inline datum
@github-actions github-actions bot removed the Stale label Mar 17, 2024
Copy link

github-actions bot commented May 1, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 1, 2024
Copy link

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants