-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ByronTx #382
Remove ByronTx #382
Conversation
} | ||
} -> map (ByronTx ByronEraOnlyByron) txs | ||
ByronBlock Consensus.ByronBlock{}-> error "getBlockTxs: Byron blocks currently not supported" | ||
-- TODO: Determine if we care about Byron blocks. Likely not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually do if QA intends to use foldBlocks with their hard forking tests. Not strictly true as foldBlocks
can be called when we enter the Shelley era. It does not make sense to call foldBlocks
in Byron because Byron does not have ledger events.
2085ee9
to
427bb5e
Compare
c171d24
to
8e2a9d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
now handle Byron transaction serialization separately
submitted with TxInByronSpecial
txs (ATxAux) Remove dead code
8e2a9d3
to
72cbddf
Compare
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist