Parameterize createAndValidateTransactionBody on ShelleyBasedEra era
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jimbo4350
force-pushed
the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
2 times, most recently
from
e26e7fb to
ee82c03
Compare
- scriptLanguageSupportedInEra - toScriptInEra - refScriptToShelleyScript
Jimbo4350
force-pushed
the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
from
ee82c03 to
ffac1c1
Compare
Jimbo4350
changed the title
createAndValidateTransactioBody on ShelleyBasedEra eracreateAndValidateTransactionBody on ShelleyBasedEra era
Jimbo4350
force-pushed
the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
5 times, most recently
from
9bd659b to
cd8a638
Compare
smelc
approved these changes
Nov 20, 2023
Jimbo4350
force-pushed
the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
from
cd8a638 to
2e9104f
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
carbolymer,
CarlosLopezDeLara and
disassembler
as code owners
Jimbo4350
commented
Nov 20, 2023
| forEraInEon era | ||
| (Left TextEnvelopeCddlErrByronKeyWitnessUnsupported) | ||
| (\sbe -> f . InAnyCardanoEra era <$> deserialiseWitnessLedgerCddl sbe teCddl) | ||
| AnyShelleyBasedEra era <- cddlTypeToEra ttoken |
There was a problem hiding this comment.
Byron witnesses were never supported in the cli: IntersectMBO/cardano-cli@2bcf5df#diff-a38343c1825e6e334224d0a8a1ba78a458652970f00c54f5fb0d040be28f822eL1247
Jimbo4350
commented
Nov 20, 2023
| @@ -270,14 +277,12 @@ deserialiseFromTextEnvelopeCddlAnyOf types teCddl = | |||
| Left (TextEnvelopeCddlTypeError expectedTypes actualType) | |||
|
|
|||
| Just (FromCDDLTx ttoken f) -> do | |||
| AnyCardanoEra era <- cddlTypeToEra ttoken | |||
| f . InAnyCardanoEra era <$> deserialiseTxLedgerCddl era teCddl | |||
| AnyShelleyBasedEra era <- cddlTypeToEra ttoken | |||
There was a problem hiding this comment.
Byron txs were read via readByronTx in cardano-cli. readByronTx needs to be moved to cardano-api.
Jimbo4350
force-pushed
the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
from
2e9104f to
76da97b
Compare
carbolymer
approved these changes
Nov 20, 2023
Add getTxIdByron
Parameterize deserialiseTxLedgerCddl, deserialiseTx on ShelleyBasedEra Parameterize constructors of FromSomeTypeCDDL on InAnyShelleyBasedEra Remove "Witnessed Tx ByronEra" from cddlTypeToEra
Jimbo4350
force-pushed
the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
from
76da97b to
82789fa
Compare
Jimbo4350
deleted the
jordan/parameterize-createAndValidateTransactionBody-ShelleyBasedEra
branch
3 tasks
newhoggy
added a commit
that referenced
this pull request
Mar 11, 2024
…-withdrawals Disambiguate treasury withdrawal flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist