Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functions anyShelleyBasedEra, inAnyCardanoEra and inAnyShelleyBasedEra #318

Closed
wants to merge 0 commits into from

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Oct 14, 2023

Changelog

- description: |
    Delete Constraints module.
    New functions `anyShelleyBasedEra`, `inAnyCardanoEra` and `inAnyShelleyBasedEra`.
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The contents have been moved to sit along CardanoEra and ShelleyBasedEra just like the other eons.

The new functions anyShelleyBasedEra, inAnyCardanoEra and inAnyShelleyBasedEra are equivalent to constructors of the same name except it is not necessary to have any constraints available at the callsite.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@newhoggy newhoggy changed the title Delete constraints module Delete Constraints module Oct 14, 2023
@newhoggy newhoggy marked this pull request as ready for review October 14, 2023 13:09
@newhoggy newhoggy changed the title Delete Constraints module New functions anyShelleyBasedEra, inAnyCardanoEra and inAnyShelleyBasedEra Oct 14, 2023
@@ -96,7 +96,7 @@ queryStateForBalancedTx era allTxIns certs = runExceptT $ do
& onNothing (left ByronEraNotSupported)

qeInMode <- pure (toEraInMode era CardanoMode)
& onNothing (left (EraConsensusModeMismatch (AnyConsensusMode CardanoMode) (cardanoEraConstraints era $ AnyCardanoEra era)))
& onNothing (left (EraConsensusModeMismatch (AnyConsensusMode CardanoMode) (anyCardanoEra era)))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some circumstances we can avoid a call to cardanoEraConstraints by using anyCardanoEra instead of AnyCardanoEra

@newhoggy newhoggy force-pushed the newhoggy/delete-Constraints-module branch from 5b1ebfa to ed37f9a Compare October 14, 2023 14:45
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@newhoggy newhoggy closed this Oct 19, 2023
@newhoggy newhoggy force-pushed the newhoggy/delete-Constraints-module branch from ed37f9a to 44ffb48 Compare October 19, 2023 00:03
newhoggy added a commit that referenced this pull request Mar 11, 2024
…ommand-structure

Tidy up query command structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants