Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fewer constraints. New MaryEraOnly eon #311

Closed
wants to merge 11 commits into from

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Oct 12, 2023

Changelog

- description: |
    Use fewer constraints.
    New `MaryEraOnly` eon
    New functions:
    - `caseMaryEraOnlyOrAlonzoEraOnwards`
    - `disjointByronEraOnlyAndShelleyBasedEra`
    - `disjointAlonzoEraOnlyAndBabbageEraOnwards`
    Deprecate:
    - `noByronEraInShelleyBasedEra`.  Use `disjointByronEraOnlyAndShelleyBasedEra` instead.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Refactoring to rely less on constraints and demand fewer constraints from our functions.
The necessary constraints are summoned using caseX functions instead.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@newhoggy newhoggy changed the title Newhoggy/use fewer constraints Use fewer constraints. New MaryEraOnly eon Oct 12, 2023
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 27, 2023
Copy link

This issue was closed because it has been stalled for 60 days with no activity.

@github-actions github-actions bot closed this Jan 27, 2024
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…-key-envelope

Fix #311 - Add Cold Committee Key text envelope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant