Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce EasyEvidence type class #309

Closed
wants to merge 1 commit into from

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Introduce MainnetValue type class
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@newhoggy
Copy link
Collaborator

newhoggy commented Oct 9, 2023

I think this could be problematic. If we code against a specific era like this, it could break on a hard fork.

For example if you're running a service and your code is using this function that says mainnet is babbage and then the hardfork takes mainnet to conway, your service stops working.

This is especially important since we no longer era cast transactions and other values.

@Jimbo4350 Jimbo4350 force-pushed the jordan/introduce-mainnet-value-typeclass branch 2 times, most recently from 9b6e310 to b3af4ae Compare October 9, 2023 17:55
@Jimbo4350 Jimbo4350 changed the title Introduce MainnetValue type class Introduce EasyEvidence type class Oct 9, 2023
@Jimbo4350 Jimbo4350 force-pushed the jordan/introduce-mainnet-value-typeclass branch from b3af4ae to 2c75ef2 Compare October 9, 2023 18:00
@Jimbo4350
Copy link
Contributor Author

forEraMaybeEon already has the functionality I was looking for

@Jimbo4350 Jimbo4350 closed this Oct 10, 2023
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…from-spo-reg

drep registration-certificate: remove mix with SPO registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants