Rename eon functions

[newhoggy]

Changelog

- description: |
    - Rename `inShelleyBasedEraEonMaybe` to `forShelleyBasedEraInEonMaybe`
    - Rename `inShelleyBasedEraEon` to `forShelleyBasedEraInEon`
    - Rename `maybeEonInShelleyBasedEra` to `forShelleyBasedEraMaybeEon`
    - Rename `eonInShelleyBasedEra` to `inEonForShelleyBasedEra`
    - Rename `maybeEonInEra` to `forEraMaybeEon`
    - Rename `inEraEonMaybe` to `forEraInEonMaybe`
    - New `inEonForEraMaybe` function
    - New `inEonForShelleyBasedEraMaybe` function
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The function names are composed on smaller positional components:

• forEra - corresponds to CardanoEra era
• forShelleyBasedEra - corresponds to ShelleyBasedEra era
• inEon - corresponds to a and eon era -> a if not coupled with maybe otherwise corresponds to just eon era -> a
• maybe - corresponds to Maybe a`
• maybeEon - corresponds to Maybe (eon era)

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• The change log section in the PR description has been filled in
• New tests are added if needed and existing tests are updated. These may include:
  • golden tests
  • property tests
  • round trip tests
  • integration tests
    See Running tests for more details
• The version bounds in .cabal files are updated
• CI passes. See note on CI. The following CI checks are required:
  • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
  • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
  • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
• The changelog section in the PR is updated to describe the change
• Self-reviewed the diff

[carbolymer]

I like the new naming better.

[Jimbo4350]

💯 just one comment however

[Jimbo4350]

👍