Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for conway era protocol parameters #252

Closed
wants to merge 4 commits into from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 19, 2023

Changelog

- description: |
    <insert-changelog-description-here>
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Part of: IntersectMBO/cardano-cli#288

Requires:

Prerequisite for:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/use-conway-pp branch from 5f616ba to 10b334b Compare September 20, 2023 08:53
@carbolymer carbolymer force-pushed the mgalazyn/fix/use-conway-pp branch 2 times, most recently from dbaacca to 26d6da3 Compare September 20, 2023 10:06
@carbolymer carbolymer changed the title #input-output-hk/cardano-cli/288 Add support for conway era protocol … Add support for conway era protocol parameters Sep 20, 2023
@carbolymer carbolymer force-pushed the mgalazyn/fix/use-conway-pp branch 2 times, most recently from d577266 to 70af1db Compare September 20, 2023 10:26
@carbolymer carbolymer force-pushed the mgalazyn/fix/use-conway-pp branch from 70af1db to 966d1f4 Compare September 28, 2023 12:55
@carbolymer
Copy link
Contributor Author

Closed in favour: #270

@carbolymer carbolymer closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants