Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON instance for Hash GenesisKey #249

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 18, 2023

Changelog

- description: |
    Add JSON instance for `Hash GenesisKey`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Instance upstreamed from cardano-cli

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as ready for review September 18, 2023 17:17
@carbolymer carbolymer marked this pull request as draft September 18, 2023 17:17
@carbolymer carbolymer force-pushed the mgalazyn/chore/add-json-instances branch from 1887a40 to a00f127 Compare September 18, 2023 18:06
@carbolymer carbolymer changed the title Add JSON instances for Keys Add JSON instance for Hash GenesisKey Sep 18, 2023
@carbolymer carbolymer marked this pull request as ready for review September 18, 2023 18:16
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to CI is correct, thanks to the recent merge of input-output-hk/actions#10

@newhoggy newhoggy added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 1268918 Sep 19, 2023
@newhoggy newhoggy deleted the mgalazyn/chore/add-json-instances branch September 19, 2023 02:24
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…atched-era-error-message

Update error message for eras mismatch between node and cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants