Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzy matching for country names #4

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

andy-isoc
Copy link
Collaborator

@andy-isoc andy-isoc commented Nov 28, 2024

Turns out heart needs the fuzzy matching so I reckon we should add it to the lib.

I noticed while doing this that the way we've structured this means you need to import regions to use any of this. I'm wondering if we should ditch the Regions class and just have everything as a top-level function? (Perhaps as a new major version of the lib as it would be a breaking change).

Also, the hdx fuzzy matching isn't very fuzzy; it just has some defined regexs for each country. I tried seeing if it would fuzzy match Amenia, and Armenib for Armenia but it wouldn't.

@andy-isoc andy-isoc requested review from madofo and garrettc November 28, 2024 14:56
@garrettc
Copy link
Contributor

I think moving the region stuff to top-level makes sense, and now is probably a good time to do it.

Copy link
Collaborator

@madofo madofo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a dev retreat in Foobarland please?

@madofo
Copy link
Collaborator

madofo commented Nov 28, 2024

On the Regions question I think removing makes sense as these functions aren't actually specific to 'regions' anyway are they?

@andy-isoc
Copy link
Collaborator Author

Can we have a dev retreat in Foobarland please?

Definitely! I hear there are some nice places to stay in the capital city, Baz

@andy-isoc andy-isoc merged commit 9ac9100 into main Nov 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants