Add fuzzy matching for country names #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
heart
needs the fuzzy matching so I reckon we should add it to the lib.I noticed while doing this that the way we've structured this means you need to import
regions
to use any of this. I'm wondering if we should ditch theRegions
class and just have everything as a top-level function? (Perhaps as a new major version of the lib as it would be a breaking change).Also, the hdx fuzzy matching isn't very fuzzy; it just has some defined regexs for each country. I tried seeing if it would fuzzy match
Amenia
, andArmenib
forArmenia
but it wouldn't.