Integrate hdx lib #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @garrettc As discussed this isn't ready to review/merge until the changes in the underlying hdx lib are published but just to give you an idea of where I've been heading. |
|
Loving this! |
|
Woo hoo! SIDS, LDC and LLDC integrated! I tried to do the merge using "Y"/"None" (which seems to be what they use already) but that didn't work. So I've stuck with the original data merge and just checked against the string "True" in the helper methods. Will probably wait and see if they merge the fix for the |
madofo
approved these changes
Nov 21, 2024
Add merge script to merge data locally Refactor and add SIDS, LDC and LLDC
andy-isoc
force-pushed
the
integrate-hdx-lib
branch
from
c476922 to
ae4cac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.